[dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions

Ferruh Yigit ferruh.yigit at intel.com
Tue Oct 20 16:52:26 CEST 2020


On 10/18/2020 3:09 PM, Andrew Rybchenko wrote:
> The legacy filter API, including rte_eth_dev_filter_supported() and
> rte_eth_dev_filter_ctrl() is removed. Flow API should be used.
> 
> examples/tep_termination build is broken.
> 
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>

<...>

> --- a/lib/librte_ethdev/rte_eth_ctrl.h
> +++ b/lib/librte_ethdev/rte_eth_ctrl.h
> @@ -43,17 +43,7 @@ enum rte_filter_type {
>    * Generic operations on filters
>    */
>   enum rte_filter_op {
> -	/** used to check whether the type filter is supported */
> -	RTE_ETH_FILTER_NOP = 0,
> -	RTE_ETH_FILTER_ADD,      /**< add filter entry */
> -	RTE_ETH_FILTER_UPDATE,   /**< update filter entry */
> -	RTE_ETH_FILTER_DELETE,   /**< delete filter entry */
> -	RTE_ETH_FILTER_FLUSH,    /**< flush all entries */
> -	RTE_ETH_FILTER_GET,      /**< get filter entry */
> -	RTE_ETH_FILTER_SET,      /**< configurations */
> -	RTE_ETH_FILTER_INFO,     /**< retrieve information */
> -	RTE_ETH_FILTER_STATS,    /**< retrieve statistics */
> -	RTE_ETH_FILTER_OP_MAX
> +	RTE_ETH_FILTER_GET,      /**< get flow API ops */
>   };

Thanks Andrew working on this,

It would be nice to have it in -rc1 to be tested better but it was received late 
for it.
I suspect there will be more cleanup here or there by time.

Since there will be a new version,
What do you thinks creating a new dev_ops, like '.flow_ops_get' and replace 
'.filter_ctrl' in this patchset?

This makes the naming/logic more clear, also allows removing a above 
'RTE_ETH_FILTER_GET'.



More information about the dev mailing list