[dpdk-dev] [PATCH v2 01/11] net/bnxt: add stingray support to core layer

[Ferruh Yigit]

On 10/21/2020 7:11 PM, Ajit Khaparde wrote:
> On Wed, Oct 21, 2020 at 11:07 AM Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>>
>> On 10/20/2020 10:55 PM, Ajit Khaparde wrote:
>>> From: Peter Spreadborough <peter.spreadborough at broadcom.com>
>>>
>>> - Moved P4 specific code under the P4 directory
>>> - Added P45 skeleton code for SR to build on
>>> - Add SR support in truflow core layer
>>>
>>
>> Related to the patch title, as far as I know Stingray device support already
>> added, what is this "core layer" that Stingray support added, can it be possible
>> to detail it in the commit log?
>>
>>> Signed-off-by: Peter Spreadborough <peter.spreadborough at broadcom.com>
>>> Signed-off-by: Jay Ding <jay.ding at broadcom.com>
>>> Reviewed-by: Farah Smith <farah.smith at broadcom.com>
>>> Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
>>
>> <...>
>>
>>> diff --git a/drivers/net/bnxt/tf_core/cfa_resource_types.h b/drivers/net/bnxt/tf_core/cfa_resource_types.h
>>> index 19838c393..a62063b0e 100644
>>> --- a/drivers/net/bnxt/tf_core/cfa_resource_types.h
>>> +++ b/drivers/net/bnxt/tf_core/cfa_resource_types.h
>>> @@ -1,6 +1,13 @@
>>> -/* SPDX-License-Identifier: BSD-3-Clause
>>> - * Copyright(c) 2019-2020 Broadcom
>>> - * All rights reserved.
>>> +/*
>>> + * Copyright(c) 2001-2020, Broadcom. All rights reserved. The
>>> + * term Broadcom refers to Broadcom Inc. and/or its subsidiaries.
>>> + * Proprietary and Confidential Information.
>>> + *
>>> + * This source file is the property of Broadcom Corporation, and
>>> + * may not be copied or distributed in any isomorphic form without
>>> + * the prior written consent of Broadcom Corporation.
>>> + *
>>> + * DO NOT MODIFY!!! This file is automatically generated.
>>>     */
>>
>> Can Broadcom provide a written consent to me to push this into the public repo? :)
>>
>>
>> I assume license updated by mistake.
> Ferruh,
> Yes. That was an oversight.
> Please upload to the files in the patch set public repo.
> I will submit a change to clean it up in a follow on patch.

Can it be possible to send a clean version and continue with it?

I am OK to fix small code issues in the tree, or by incremental fixes and squash 
them, but not sure about doing same for above note.

Thanks,
ferruh

> Apologize for the inconvenience.
> 
> Thanks
> Ajit
> 
>>