[dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value

Zhang, Qi Z qi.z.zhang at intel.com
Fri Oct 23 02:59:19 CEST 2020



> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Wang, Haiyue
> Sent: Wednesday, October 21, 2020 1:06 AM
> To: Walsh, Conor <conor.walsh at intel.com>; Guo, Jia <jia.guo at intel.com>;
> Yigit, Ferruh <ferruh.yigit at intel.com>; Awal, Mohammad Abdul
> <mohammad.abdul.awal at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>; stable at dpdk.org
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value
> 
> > -----Original Message-----
> > From: Walsh, Conor <conor.walsh at intel.com>
> > Sent: Tuesday, October 20, 2020 18:03
> > To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue
> > <haiyue.wang at intel.com>; Yigit, Ferruh <ferruh.yigit at intel.com>; Awal,
> > Mohammad Abdul <mohammad.abdul.awal at intel.com>; Doherty, Declan
> > <declan.doherty at intel.com>; stable at dpdk.org
> > Cc: dev at dpdk.org; Walsh, Conor <conor.walsh at intel.com>
> > Subject: [PATCH v2 1/2] net/ixgbe: fix unchecked return value
> >
> > The return value of rte_eth_switch_domain_alloc() was not being
> > checked within ixgbe_pf_host_init() which caused a coverity issue. If
> > the call fails a warning is logged using PMD_INIT_LOG() and *vfinfo is free'd.
> > ixgbe_pf_host_init() now has a return value which is checked in
> > eth_ixgbe_dev_init()
> >
> > Coverity issue: 362795
> > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
> >
> > Signed-off-by: Conor Walsh <conor.walsh at intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++++--
> > drivers/net/ixgbe/ixgbe_ethdev.h |  2 +-
> >  drivers/net/ixgbe/ixgbe_pf.c     | 16 +++++++++++++---
> >  3 files changed, 23 insertions(+), 6 deletions(-)
> 
> Acked-by: Haiyue Wang <haiyue.wang at intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi



More information about the dev mailing list