[dpdk-dev] [PATCH 14/62] common/sfc_efx/base: add action set spec init/fini APIs

[Ali Alnubani]

Hi,

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Andrew Rybchenko
> Sent: Tuesday, October 20, 2020 11:48 AM
> To: y at solarflare.com
> Cc: dev at dpdk.org; Ivan Malov <ivan.malov at oktetlabs.ru>
> Subject: [dpdk-dev] [PATCH 14/62] common/sfc_efx/base: add action set
> spec init/fini APIs
> 
> From: Ivan Malov <ivan.malov at oktetlabs.ru>
> 
> The engine is only able to carry out chosen actions on matching packets in a
> strict order. No MCDI exists to identify supported actions and the order.
> Still, the definition of the latter is available from the FW documentation.
> 
> The general idea is to define an action specification structure and supply a
> client driver with APIs for adding actions individually, order-dependent.
> A client driver is supposed to invoke an API on every action passed by the
> application, and if an out-of-order action follows, the API will reject it.
> 
> Add an action set specification stub and supply initialise / finalise APIs.
> 
> Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
> Reviewed-by: Andy Moreton <amoreton at xilinx.com>
> ---

This patch is causing the following build failure on CentOS 7 with clang 3.4.2:

"""
In file included from drivers/common/sfc_efx/base/efx_crc32.c:8:
drivers/common/sfc_efx/base/efx_impl.h:1703:3: error: redefinition of typedef 'efx_mae_actions_t' is a C11 feature [-Werror,-Wtypedef-redefinition]
} efx_mae_actions_t;
drivers/common/sfc_efx/base/efx.h:4101:34: note: previous definition is here
typedef struct efx_mae_actions_s efx_mae_actions_t;
"""

Regards,
Ali