[dpdk-dev] [PATCH v1 37/72] mlx5/windows: add mlx5_os header file under net

Thomas Monjalon thomas at monjalon.net
Wed Oct 28 08:18:51 CET 2020


28/10/2020 00:23, Ophir Munk:
> File drivers/net/mlx5/windows/mlx5_os.h is added. It includes specific
> Windows definitions such as PCI driver flags link state changes
> interrupts, link removal interrupts.

The description does not match the content below.

> Signed-off-by: Ophir Munk <ophirmu at nvidia.com>
> ---
> --- /dev/null
> +++ b/drivers/net/mlx5/windows/mlx5_os.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2020 Mellanox Technologies, Ltd
> + */
> +
> +#ifndef RTE_PMD_MLX5_OS_H_
> +#define RTE_PMD_MLX5_OS_H_
> +/* sysfs equivalent under Windows */
> +enum {
> +	SYSFS_NAME_MAX = 64,
> +	SYSFS_PATH_MAX = 256
> +};
> +enum {
> +	DEV_SYSFS_NAME_MAX = SYSFS_NAME_MAX + 1,
> +	DEV_SYSFS_PATH_MAX = SYSFS_PATH_MAX + 1
> +};

There is no sysfs on Windows, so why do you need these definitions?

> +
> +#define PCI_DRV_FLAGS 0
> +
> +#endif /* RTE_PMD_MLX5_OS_H_ */






More information about the dev mailing list