[dpdk-dev] [PATCH 7/8] event: switch sequence number to dynamic field

[Jerin Jacob]

On Wed, Oct 28, 2020 at 2:25 PM David Marchand
<david.marchand at redhat.com> wrote:
>
> On Wed, Oct 28, 2020 at 8:27 AM Jerin Jacob <jerinjacobk at gmail.com> wrote:
> > > diff --git a/app/test-eventdev/test_order_common.h b/app/test-eventdev/test_order_common.h
> > > index 9e3415e421..d4ad31da46 100644
> > > --- a/app/test-eventdev/test_order_common.h
> > > +++ b/app/test-eventdev/test_order_common.h

> >
> > Could you change symbol name to rte_event_dev_selftest_seqn_dynfield_offset()
> > to limit the scope only to self test. also, it is not required to expose
> > rte_event_test_seqn_dynfield_register() in that case.
>
> How about moving this to rte_eventdev_pmd.h and make it a pmd only API?
> => rte_event_pmd_ prefix

+1

>
> I would mark it rte_internal too.

Ack.

>
>
> --
> David Marchand
>