[dpdk-dev] [PATCH v4 13/15] examples/bbdev: switch to dynamic mbuf field

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Wed Oct 28 12:51:52 CET 2020


On 10/28/20 1:26 PM, Thomas Monjalon wrote:
> The example used the deprecated mbuf field udata64 as input mbuf pointer.
> It is moved to a dynamic field in order to allow removal of udata64.
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>

I like the approach with inline function(s) more than approach
with macros. Not sure that get/set is needed. Approach in
David's patches looks a bit simpler to me - less duplicated
code (i.e. just one function which returns pointer of correct
type to a dynamic field and allow to get and set it).


More information about the dev mailing list