[dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

[Thomas Monjalon]

29/10/2020 12:02, Andrew Rybchenko:
> On 10/29/20 12:27 PM, Thomas Monjalon wrote:
> > +/* variables are exported because this file is included in other drivers */
> > +extern uint64_t rte_pmd_octeontx2_timestamp_rx_dynflag;
> > +extern int rte_pmd_octeontx2_timestamp_dynfield_offset;
> > +
> > +static inline rte_mbuf_timestamp_t *
> > +otx2_timestamp_dynfield(struct rte_mbuf *mbuf)
> > +{
> > +	return RTE_MBUF_DYNFIELD(mbuf,
> > +		rte_pmd_octeontx2_timestamp_dynfield_offset,
> > +		rte_mbuf_timestamp_t *);
> > +}
> > +
> 
> May be ethdev should provide the inline function?

It would mean exporting the offsets.

And actually I think this field should not be restricted to ethdev.