[dpdk-dev] [PATCH] net: add a new network PMD named txgbe

[jiawenwu at trustnetic.com]

Hi Ferruh,

Since this patch is too large, it needs to be split into so many small patches, which takes a lot of time.
Therefore, I first created a part of patches to contribute. And if there is a review problem with these patches, please let me know as soon.
And I will complete the remaining patches in the next 3~4 days.

Thanks.

-----Original Message-----
From: jiawenwu at trustnetic.com <jiawenwu at trustnetic.com> 
Sent: Friday, August 21, 2020 10:22 AM
To: 'Ferruh Yigit' <ferruh.yigit at intel.com>; 'dev at dpdk.org' <dev at dpdk.org>
Cc: 'jianwang at trustnetic.com' <jianwang at trustnetic.com>; 'yuhongzhang at trustnetic.com' <yuhongzhang at trustnetic.com>
Subject: RE: [PATCH] net: add a new network PMD named txgbe

Hi Ferruh,

Thanks for your suggestion. I'll split the patch into a patchset as soon as possible.

-----Original Message-----
From: Ferruh Yigit <ferruh.yigit at intel.com> 
Sent: Thursday, August 20, 2020 7:49 PM
To: Jiawen Wu <jiawenwu at trustnetic.com>; dev at dpdk.org
Cc: jianwang at trustnetic.com; yuhongzhang at trustnetic.com
Subject: Re: [PATCH] net: add a new network PMD named txgbe

On 8/20/2020 4:02 AM, Jiawen Wu wrote:
> This is a new network PMD named txgbe provides poll mode driver support for Wangxun 10Gb Ethernet NICs.
> 
> Beijing WangXun Technology Co., Ltd. is a high-tech company specializing in the design of high-end integrated circuit chips and providing independent innovation solutions for enterprise network and storage products. Founded in May 2014, the company is headquartered in Beijing YuQuanHuiGu Science and Technology Park, with branches in Hangzhou City. Welcome to reach us on website https://www.net-swift.com.
> 
> This patch is created base on the main branch in main repository. Our goal is to validate and commit txgbe driver into the 20.11 official release, and then continue the development and maintenance in community.
> 
> Waiting for your reviews sincerely.
> 
> Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>

Hi Jiawen,

Thanks for the patch.

Without looking into any detail, a very high level comment is, it is very hard to review a new PMD (40K+ loc) as a single patch.

Can you please split the patch into multiple patches, which gradually build the PMD by adding a feature with each patch, starting from an empty skeleton.

Last as few upstreamed PMDs as example:
ionic:
https://patches.dpdk.org/project/dpdk/list/?series=8206&state=%2A&archive=both

pfe:
https://patches.dpdk.org/project/dpdk/list/?series=6777&state=%2A&archive=both

octeontx2 (one of the good samples I suggest checking):
https://patches.dpdk.org/project/dpdk/list/?series=5302&state=%2A&archive=both


Also you can skip all Makefile build system related changes, since it will be removed in this release, no need to spend time for it.

Thanks,
ferruh