[dpdk-dev] [PATCH 1/9] net/i40e/base: add VLAN field for input set

[Ferruh Yigit]

On 9/5/2020 3:49 AM, Guinan Sun wrote:
> Add VLAN bit used during flow director programming, as a part of
> input set for HW.
> 
> Signed-off-by: Przemyslaw Patynowski <przemyslawx.patynowski at intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun at intel.com>
> ---
>  drivers/net/i40e/base/i40e_type.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h
> index cf4134583..c8e7164e1 100644
> --- a/drivers/net/i40e/base/i40e_type.h
> +++ b/drivers/net/i40e/base/i40e_type.h
> @@ -1926,6 +1926,8 @@ struct i40e_lldp_variables {
>  #define I40E_L4_DST_MASK		(0x1ULL << I40E_L4_DST_SHIFT)
>  #define I40E_VERIFY_TAG_SHIFT		31
>  #define I40E_VERIFY_TAG_MASK		(0x3ULL << I40E_VERIFY_TAG_SHIFT)
> +#define I40E_VLAN_SRC_SHIFT		55
> +#define I40E_VLAN_SRC_MASK		(0x1ULL << I40E_VLAN_SRC_SHIFT)
>  
>  #define I40E_FLEX_50_SHIFT		13
>  #define I40E_FLEX_50_MASK		(0x1ULL << I40E_FLEX_50_SHIFT)
> 

Hi Guinan, Qi,

These new defines in the base code seems not used by driver, is there a benefit
to add them now?
What do you think to add them when they are used by the driver code?