[dpdk-dev] [PATCH v4 01/22] event/dlb: add documentation and meson infrastructure

Eads, Gage gage.eads at intel.com
Mon Sep 14 22:56:01 CEST 2020


> diff --git a/doc/guides/eventdevs/dlb.rst b/doc/guides/eventdevs/dlb.rst
> new file mode 100644
> index 0000000..e5759c0
> --- /dev/null
> +++ b/doc/guides/eventdevs/dlb.rst

Please add a dlb entry to doc/guides/eventdevs/index.rst

> @@ -0,0 +1,340 @@
> +..  SPDX-License-Identifier: BSD-3-Clause
> +    Copyright(c) 2020 Intel Corporation.
> +
> +Driver for the Intel® Dynamic Load Balancer (DLB)
> +==================================================
> +
> +The DPDK dlb poll mode driver supports the Intel® Dynamic Load Balancer.
> +
> +Prerequisites
> +-------------
> +
> +- Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to
> setup
> +  the basic DPDK environment.

It would be better to remove the bullet point ('-'), I think, since there's only
One sentence in the section.

> +
> +Configuration
> +-------------
> +
> +* The DLB PF PMD is a user-space PMD that uses VFIO to gain direct
> +  device access. To use this operation mode, the PCIe PF device must be
> bound
> +  to a DPDK-compatible VFIO driver, such as vfio-pci.

Same here ('*')

[...]

> +Atomic Inflights Allocation
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +In the last stage prior to scheduling an atomic event to a CQ, DLB holds the
> +inflight event in a temporary buffer that is divided among load-balanced
> +queues. If a queue's atomic buffer storage fills up, this can result in
> +head-of-line-blocking. For example:

You need a space between these two lines for doxygen to render the bullet
points properly.

Thanks,
Gage



More information about the dev mailing list