[dpdk-dev] [PATCH v2 00/17] Replace terms master/slave

Burakov, Anatoly anatoly.burakov at intel.com
Tue Sep 15 12:09:24 CEST 2020


On 14-Sep-20 7:19 PM, Stephen Hemminger wrote:
> As announced in 20.08 release notes, the terms for lcore role
> will change in 20.11 release.
> 
> This is a project wide patchset to terminolgy used for DPDK lcore.
> The term "master" referring to lcore is replaced with "main" and
> "slave" lcore is replaced with "worker" lcore.
> 
> This is most visible in API for rte_get_master_lcore() which is
> replaced with rte_get_main_lcore(). And the macros for iterating
> over lcores are replaced as well.
> 
> The first patch introduces a way to mark macro's as deprecated
> as well.
> 
> v2
>     - fix more places found by Anatoly and grep
>     - add coding style update
>     - add memif changes
> 

More missed places:

doc/guides/linux_gsg/quick_start.rst
   235,10:     EAL: Master core 0 is ready (tid=1b2ad720)
   297,10:     EAL: Master core 0 is ready (tid=de25b700)

doc/guides/sample_app_ug/performance_thread.rst
   1220,27: main EAL thread after all slave threads have stopped and 
returned to the C

drivers/bus/pci/pci_common_uio.c
   54,27: 			/* fd is not needed in slave process, close it */

drivers/bus/vmbus/vmbus_common_uio.c
   88,25: 	/* fd is not needed in slave process, close it */

drivers/event/dpaa2/dpaa2_eventdev_selftest.c
   504,31: launch_workers_and_wait(int (*master_worker)(void *),
   505,10: 			int (*slave_workers)(void *), uint32_t total_events,
   540,12: 			/* skip master */ 1,
   542,24: 	rte_eal_remote_launch(master_worker, &param[0], w_lcore);
   551,25: 		rte_eal_remote_launch(slave_workers, &param[port], w_lcore);

drivers/event/octeontx/ssovf_evdev_selftest.c
   604,31: launch_workers_and_wait(int (*master_worker)(void *),
   605,10: 			int (*slave_workers)(void *), uint32_t total_events,
   640,12: 			/* skip master */ 1,
   642,24: 	rte_eal_remote_launch(master_worker, &param[0], w_lcore);
   651,25: 		rte_eal_remote_launch(slave_workers, &param[port], w_lcore);

drivers/event/sw/sw_evdev_selftest.c
   3111,12: 			/* skip master */ 1,

drivers/net/softnic/rte_eth_softnic_internals.h
   550,4:  * Master thead: data plane thread context

drivers/net/softnic/rte_eth_softnic_thread.c
   21,4:  * Master thread: data plane thread init
   81,6: 		/* Master thread records */
   212,4:  * Master thread & data plane threads: message passing
   246,4:  * Master thread
   590,4:  * Master thread & data plane threads: message passing
   756,4:  * Master thread

lib/librte_eal/linux/eal_memory.c
   1740,55: 	 *    --socket-mem, we allocate all of our memory on master 
core socket.

lib/librte_kni/rte_kni.h
   83,43:  * This function is to be executed on the MASTER lcore only, 
after EAL

-- 
Thanks,
Anatoly


More information about the dev mailing list