[dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd

Burakov, Anatoly anatoly.burakov at intel.com
Thu Sep 17 14:56:12 CEST 2020


On 19-May-20 4:42 AM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian at huawei.com>
> 
> The issue is that a file descriptor at 0 is a valid one. Currently
> the file not found, the return value will be set to 0. As a result,
> it is impossible to distinguish between a correct descriptor and a
> failed return value. Fix it to return -ENOENT instead of 0.
> 
> Fixes: a69f79300262 ("bus/fslmc: support multi VFIO group")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> ---

I am unfamiliar with bus/fslmc code but i've taken a quick look, and 
i've noticed that there's another instance of get_group_fd() usage that 
you're not modifying - is that intentional?

-- 
Thanks,
Anatoly


More information about the dev mailing list