[dpdk-dev] [PATCH V7 1/3] ethdev: introduce FEC API

[Andrew Rybchenko]

On 9/18/20 9:10 PM, Ajit Khaparde wrote:
> On Fri, Sep 18, 2020 at 5:13 AM Ananyev, Konstantin
> <konstantin.ananyev at intel.com> wrote:
>>
>>> This patch adds Forward error correction(FEC) support for ethdev.
>>> Introduce APIs which support query and config FEC information in
>>> hardware.
>>>
>>> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
>>> Reviewed-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
>>> Reviewed-by: Chengwen Feng <fengchengwen at huawei.com>
>>> Reviewed-by: Chengchang Tang <tangchengchang at huawei.com>
>>> ---
>>> v6->v7:
>>> deleted RTE_ETH_FEC_NUM to prevent ABI breakage.
>>> add new macro to indicate translation from fec mode
>>> to capa.
>>>
>>> ---
>>> v5->v6:
>>> modified release notes.
>>> deleted check duplicated for FEC API
>>> fixed code styles according to DPDK coding style.
>>> added _eth prefix.
>>>
>>> ---
>>> v4->v5:
>>> Modifies FEC capa definitions using macros.
>>> Add RTE_ prefix for public FEC mode enum.
>>> add release notes about FEC for dpdk20_11.
>>>
>>> ---
>>> v2->v3:
>>> add function return value "-ENOTSUP" for API
>>>
>>> ---
>> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>

I'm sorry, but I'm still unhappy with enum members order and
get capabilities API. See v5 notes.