[dpdk-dev] [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas

[Eads, Gage]

> -----Original Message-----
> From: Steven Lariau <steven.lariau at arm.com>
> Sent: Friday, September 11, 2020 10:30 AM
> To: Eads, Gage <gage.eads at intel.com>; Olivier Matz <olivier.matz at 6wind.com>
> Cc: dev at dpdk.org; nd at arm.com; dharmik.thakkar at arm.com; Steven Lariau
> <steven.lariau at arm.com>
> Subject: [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas
> 
> Fix cmpexchange usage of weak / strong.
> The generated code is the same on x86 and ARM (there is no weak
> cmpexchange), but the old usage was inconsistent.
> For push and pop update size, weak is used because cmpexchange is inside
> a loop.
> For pop update root, strong is used even though cmpexchange is inside a
> loop, because there may be a lot of operations to do in a loop iteration
> (locate the new head).
> 
> Signed-off-by: Steven Lariau <steven.lariau at arm.com>
> Reviewed-by: Dharmik Thakkar <dharmik.thakkar at arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>

Acked-by: Gage Eads <gage.eads at intel.com>

Thanks,
Gage