[dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language

David Marchand david.marchand at redhat.com
Wed Sep 23 13:45:33 CEST 2020


Hello Cristian,

On Thu, Sep 10, 2020 at 5:27 PM Cristian Dumitrescu
<cristian.dumitrescu at intel.com> wrote:
> Cristian Dumitrescu (41):
>   pipeline: add new SWX pipeline type
>   pipeline: add SWX pipeline input port
>   pipeline: add SWX pipeline output port
>   pipeline: add SWX headers and meta-data
>   pipeline: add SWX extern objects and funcs
>   pipeline: add SWX pipeline action
>   pipeline: add SWX pipeline tables
>   pipeline: add SWX pipeline instructions
>   pipeline: add SWX rx and extract instructions
>   pipeline: add SWX tx and emit instructions
>   pipeline: add header validate and invalidate SWX instructions
>   pipeline: add SWX mov instruction
>   pipeline: add SWX dma instruction
>   pipeline: introduce SWX add instruction
>   pipeline: introduce SWX sub instruction
>   pipeline: introduce SWX ckadd instruction
>   pipeline: introduce SWX cksub instruction
>   pipeline: introduce SWX and instruction
>   pipeline: introduce SWX or instruction
>   pipeline: introduce SWX xor instruction
>   pipeline: introduce SWX shl instruction
>   pipeline: introduce SWX shr instruction
>   pipeline: introduce SWX table instruction
>   pipeline: introduce SWX extern instruction
>   pipeline: introduce SWX jmp and return instructions
>   pipeline: add SWX instruction description
>   pipeline: add SWX instruction verifier
>   pipeline: add SWX instruction optimizer
>   pipeline: add SWX pipeline query API
>   pipeline: add SWX pipeline flush
>   pipeline: add SWX table update high level API
>   pipeline: add SWX pipeline specification file
>   port: add ethernet device SWX port
>   port: add source and sink SWX ports
>   table: add exact match SWX table
>   examples/pipeline: add new example application
>   examples/pipeline: add message passing mechanism
>   examples/pipeline: add configuration commands
>   examples/pipeline: add l2fwd example
>   examples/pipeline: add l2fwd with MAC swap example
>   examples/pipeline: add VXLAN encapsulation example

- This new feature is the future of the pipeline library: it will need
unit tests and/or tests in the CI to catch regressions.

- Many MACRO_WITH_FLOW_CONTROL warnings reported by checkpatches.

- On the patch titles, check-git-log.sh reports:
Wrong headline case:
            "pipeline: add SWX dma instruction": dma --> DMA
Wrong headline case:
            "pipeline: add SWX rx and extract instructions": rx --> Rx
Wrong headline case:
            "pipeline: add SWX tx and emit instructions": tx --> Tx
Wrong headline case:
            "pipeline: introduce SWX xor instruction": xor --> XOR

- We have yet another new example, please declare it in MAINTAINERS.

- I checked per patch compilation which is fine, thanks.


-- 
David Marchand



More information about the dev mailing list