[dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline type

Stephen Hemminger stephen at networkplumber.org
Wed Sep 23 20:24:38 CEST 2020


On Wed, 23 Sep 2020 19:06:05 +0100
Cristian Dumitrescu <cristian.dumitrescu at intel.com> wrote:

> +/*
> + * Pipeline.
> + */
> +struct rte_swx_pipeline {
> +	int build_done;
> +	int numa_node;
> +};
> +

Nit, could build_done be a bool type?

+void
+rte_swx_pipeline_free(struct rte_swx_pipeline *p)
+{
+	if (!p)
+		return;
+
+	free(p);
+}

The free() function in libc is defined to accept NULL as ok.
Please remove the if()



More information about the dev mailing list