[dpdk-dev] [PATCH 07/20] net/failsafe: release port upon close

[Thomas Monjalon]

> +int
> +failsafe_eth_dev_close(struct rte_eth_dev *dev)
> +{
> +       struct sub_device *sdev;
> +       uint8_t i;
> +       int ret;
> +
> +       fs_lock(dev, 0);
> +       failsafe_hotplug_alarm_cancel(dev);
> +       if (PRIV(dev)->state == DEV_STARTED)
> +               dev->dev_ops->dev_stop(dev);
> +       PRIV(dev)->state = DEV_ACTIVE - 1;
> +       FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {
> +               DEBUG("Closing sub_device %d", i);
> +               failsafe_eth_dev_unregister_callbacks(sdev);
> +               rte_eth_dev_close(PORT_ID(sdev));
> +               sdev->state = DEV_ACTIVE - 1;
> +       }
> +       fs_dev_free_queues(dev);
> +       rte_eth_dev_callback_unregister(RTE_ETH_ALL, RTE_ETH_EVENT_NEW,
> +                                       failsafe_eth_new_event_callback,
> dev); +       ret = failsafe_eal_uninit(dev);
> +       if (ret)
> +               ERROR("Error while uninitializing sub-EAL");
> +       failsafe_args_free(dev);
> +       rte_free(PRIV(dev)->subs);
> +       ret = pthread_mutex_destroy(&PRIV(dev)->hotplug_mutex);
> +       if (ret)
> +               ERROR("Error while destroying hotplug mutex");

Note to self:
The mutex must be destroyed after it is unlocked below in fs_unlock().
Thanks Wael for the report.

> +       rte_free(PRIV(dev)->mcast_addrs);
> +       /* mac_addrs must not be freed alone because part of dev_private */
> +       dev->data->mac_addrs = NULL;
> +       fs_unlock(dev, 0);
> +       return 0;
> +}