[dpdk-dev] [PATCH v7 01/10] usertools/dpdk-telemetry-client: support python3 only

Robin Jarry robin.jarry at 6wind.com
Fri Sep 25 16:32:56 CEST 2020


Hi Kevin, all,

2020-09-21, Kevin Laatz:
> From: Louise Kilheeney <louise.kilheeney at intel.com>
> 
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
> 
> Cc: Kevin Laatz <kevin.laatz at intel.com>
> 
> Signed-off-by: Louise Kilheeney <louise.kilheeney at intel.com>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
[snip]
> -                self.unregister();
> +                self.unregister()

Is this related to Python 3? If not, it may be better to make code
cleanups in a separate series.

>          except:
>              print("Error - Client could not be destroyed")
>  
> @@ -86,7 +74,7 @@ def requestMetrics(self): # Requests metrics for given client
>  
>      def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
>          print("\nPlease enter the number of times you'd like to continuously request Metrics:")
> -        n_requests = int(raw_input("\n:"))
> +        n_requests = int(input("\n:"))
>          print("\033[F") #Removes the user input from screen, cleans it up
>          print("\033[K")
>          for i in range(n_requests):
> @@ -107,7 +95,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
>              print("[4] Unregister client")
>  
>              try:
> -                self.choice = int(raw_input("\n:"))
> +                self.choice = int(input("\n:"))
>                  print("\033[F") #Removes the user input for screen, cleans it up
>                  print("\033[K")
>                  if self.choice == 1:
> -- 
> 2.25.1
> 

-- 
Robin


More information about the dev mailing list