[dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker
Dybkowski, AdamX
adamx.dybkowski at intel.com
Mon Sep 28 12:17:59 CEST 2020
> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang at arm.com>
> Sent: Monday, 28 September, 2020 04:50
> To: Dybkowski, AdamX <adamx.dybkowski at intel.com>; dev at dpdk.org;
> Trahe, Fiona <fiona.trahe at intel.com>; Akhil.goyal at nxp.com; Zhang, Roy
> Fan <roy.fan.zhang at intel.com>
> Cc: nd <nd at arm.com>
> Subject: RE: [dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker
>
> > -----Original Message-----
> > From: dev <dev-bounces at dpdk.org> On Behalf Of Adam Dybkowski
> > Sent: Wednesday, August 26, 2020 11:34 PM
> > To: dev at dpdk.org; fiona.trahe at intel.com; Akhil.goyal at nxp.com;
> > roy.fan.zhang at intel.com
> > Cc: Adam Dybkowski <adamx.dybkowski at intel.com>
> > Subject: [dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker
> >
> > This patch replaces the usage of the word 'slave' with more
> > appropriate word 'worker' in QAT PMD and Scheduler PMD as well as in
> > their docs. Also the test app was modified to use the new wording.
> >
> > The Scheduler PMD's public API was modified according to the previous
> > deprecation notice:
> > rte_cryptodev_scheduler_slave_attach is now called
> > rte_cryptodev_scheduler_worker_attach,
> > rte_cryptodev_scheduler_slave_detach is
> > rte_cryptodev_scheduler_worker_detach,
> > rte_cryptodev_scheduler_slaves_get is
> > rte_cryptodev_scheduler_workers_get.
> >
> > Also, the configuration value
> > RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES
> > was renamed to RTE_CRYPTODEV_SCHEDULER_MAX_NB_WORKERS.
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski at intel.com>
> > ---
> > app/test-crypto-perf/main.c | 2 +-
> > app/test/test_cryptodev.c | 20 +-
> > doc/guides/cryptodevs/qat.rst | 2 +-
> > doc/guides/cryptodevs/scheduler.rst | 40 ++--
> > doc/guides/rel_notes/deprecation.rst | 2 +-
> > .../scheduler/rte_cryptodev_scheduler.c | 114 +++++-----
> > .../scheduler/rte_cryptodev_scheduler.h | 35 ++-
> > .../rte_cryptodev_scheduler_operations.h | 12 +-
> > .../rte_pmd_crypto_scheduler_version.map | 6 +-
> > drivers/crypto/scheduler/scheduler_failover.c | 83 +++----
> > .../crypto/scheduler/scheduler_multicore.c | 54 ++---
> > .../scheduler/scheduler_pkt_size_distr.c | 142 ++++++------
> > drivers/crypto/scheduler/scheduler_pmd.c | 54 ++---
> > drivers/crypto/scheduler/scheduler_pmd_ops.c | 204
> > +++++++++--------- .../crypto/scheduler/scheduler_pmd_private.h | 12 +-
> > .../crypto/scheduler/scheduler_roundrobin.c | 87 ++++----
> > examples/l2fwd-crypto/main.c | 6 +-
> > 17 files changed, 439 insertions(+), 436 deletions(-)
> >
>
> <snip>
>
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 345c38d5b..24d58060f 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -341,4 +341,4 @@ Deprecation Notices
> > * dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > ``make``. Given environments are too much variables for such a
> > simple script,
> > it will be removed in DPDK 20.11.
> > - Some useful parts may be converted into specific scripts.
> > + Some useful parts may be converted into specific scripts.
> > \ No newline at end of file
>
> This is not intended modification.
> What should be deleted is section 'scheduler'.
> And release note 20.11 needs update to indicate the API replacement.
>
> Thanks.
> Ruifeng
[Adam] OK, thanks for spotting this unintended modification.
I'll send the next version together with release notes update later this week.
Adam Dybkowski
More information about the dev
mailing list