[dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

[Kinsella, Ray]

On 05/08/2020 12:17, Dmitry Kozlyuk wrote:
> On Wed, 5 Aug 2020 10:31:31 +0100, Kinsella, Ray wrote:
>> On 30/07/2020 22:06, Dmitry Kozlyuk wrote:
>>> struct cmdline exposes platform-specific members it contains, most
>>> notably struct termios that is only available on Unix. Make the
>>> structure opaque.
>>>
>>> Remove tests checking struct cmdline content as meaningless.
>>>
>>> Add cmdline_get_rdline() to access history buffer.
>>> The new function is currently used only in tests.  
>>
>> Should it be INTERNAL then? Is it useful outside of the test cases?
> 
> There are already exposed rdline_*() functions that require struct rdline
> pointer, which is now only accessible via this function for struct cmdline
> instances. Thus, public API would be broken with INTERNAL for such use cases.
> 

Right but that runs a bit contrary to what you said in the commit log.

"Add cmdline_get_rdline() to access history buffer.
The new function is currently used only in tests."

In anycase, given the elapse in time since my feedback.
I will ACK the changes to MAP file. 

Ray K