[dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload
David Marchand
david.marchand at redhat.com
Thu Apr 1 14:04:10 CEST 2021
On Wed, Mar 17, 2021 at 7:50 AM Xiao Wang <xiao.w.wang at intel.com> wrote:
>
> When parsing the virtio net header and packet header for dequeue offload,
> we need to perform sanity check on the packet header to ensure:
> - No out-of-boundary memory access.
> - The packet header and virtio_net header are valid and aligned.
>
> Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
> Cc: stable at dpdk.org
>
> Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>
I spent some time digging on this topic.
Afaiu the offload API, vhost is not supposed to populate tx offloads.
I would drop this whole parse_ethernet function and replace
vhost_dequeue_offload with what virtio does on the rx side.
Please have a look at this series (especially the last patch):
http://patchwork.dpdk.org/project/dpdk/list/?series=16052
Thanks.
--
David Marchand
More information about the dev
mailing list