[dpdk-dev] [RFC] devtools: improve DPDK review process
Burakov, Anatoly
anatoly.burakov at intel.com
Fri Apr 2 18:23:10 CEST 2021
On 02-Apr-21 2:43 PM, Jerin Jacob wrote:
> On Thu, Apr 1, 2021 at 2:35 PM Anatoly Burakov
> <anatoly.burakov at intel.com> wrote:
>>
>> A common problem on the DPDK mailing list is lack of reviewers for
>> patches. This script is intended to help with that problem, by picking
>> a random commit author from our git history, and adding a Reviewed-by:
>> tag. This can be added to e.g. commit-msg git hook, like so:
>>
>> # add reviewer to commit message
>> $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
>>
>> Now all DPDK code will definitely be well reviewed!
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
>> Rеviеwеd-by: Thоmas Mоnjаlоn <thomas at monjalon.net>
>
> Looks like shuf aliased to "git shortlog --numbered --summary | head -n 1"
>
>> ---
>> devtools/get-reviewer.sh | 4 ++++
>> 1 file changed, 4 insertions(+)
>> create mode 100755 devtools/get-reviewer.sh
>>
>> diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
>> new file mode 100755
>> index 0000000000..f4b07c9862
>> --- /dev/null
>> +++ b/devtools/get-reviewer.sh
>> @@ -0,0 +1,4 @@
>> +#!/bin/sh
>> +
>> +# find a reviewer for the code
>> +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
>
> Leaving the fun part aside,
>
> Looks like we can really improve the situation by
> doing git annotate(to get the original author) of couple lines below
> and above current patch
> that changes lines.
>
> Thoughts?
>
>
>> --
>> 2.25.1
>>
Original author or the person unlucky enough to have been the latest one
to modify the lines in question? :)
It could be useful, but IMO it'll also result in a lot of noise. People
already seem to be very generous with CC's so i don't think *letting
people know* is the issue; finding time to review is.
--
Thanks,
Anatoly
More information about the dev
mailing list