[dpdk-dev] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

Li, Xiaoyun xiaoyun.li at intel.com
Wed Apr 7 04:30:54 CEST 2021


Hi

> -----Original Message-----
> From: Yu, DapengX <dapengx.yu at intel.com>
> Sent: Thursday, April 1, 2021 16:29
> To: Li, Xiaoyun <xiaoyun.li at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>
> Cc: dev at dpdk.org; Yu, DapengX <dapengx.yu at intel.com>; stable at dpdk.org
> Subject: [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd
> 
> From: Dapeng Yu <dapengx.yu at intel.com>
> 
> Configure per queue rx offloading and per queue tx offloading command
> shouldn't trigger the rte_eth_dev_configure() to reconfigure device.
> 
> The patch sets the queue reconfiguration flag only, and does not set the device
> reconfiguration flag. Therefore after port is restarted,
> rte_eth_dev_configure() will not be called again.
> 
> Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu at intel.com>
> ---
>  app/test-pmd/cmdline.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 14110eb2e..b49e9f52b 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -15626,7 +15626,7 @@ cmd_config_per_queue_rx_offload_parsed(void
> *parsed_result,
>  	else
>  		port->rx_conf[queue_id].offloads &= ~single_offload;
> 
> -	cmd_reconfig_device_queue(port_id, 1, 1);
> +	cmd_reconfig_device_queue(port_id, 0, 1);
>  }
> 
>  cmdline_parse_inst_t cmd_config_per_queue_rx_offload = { @@ -16044,7
> +16044,7 @@ cmd_config_per_queue_tx_offload_parsed(void *parsed_result,
>  	else
>  		port->tx_conf[queue_id].offloads &= ~single_offload;
> 
> -	cmd_reconfig_device_queue(port_id, 1, 1);
> +	cmd_reconfig_device_queue(port_id, 0, 1);
>  }
> 
>  cmdline_parse_inst_t cmd_config_per_queue_tx_offload = {
> --
> 2.27.0

Acked-by: Xiaoyun Li <xiaoyun.li at intel.com>


More information about the dev mailing list