[dpdk-dev] [EXT] Re: [PATCH 1/6] baseband: introduce NXP LA12xx driver

[Akhil Goyal]

Hi Hemant/Nipun,

Could you please send a new version soon?
If review is completed, I would like to take it in RC1, i.e. 15th March.

Regards,
Akhil
> 
> On 3/18/2021 8:23 PM, David Marchand wrote:
> > On Thu, Mar 18, 2021 at 7:38 AM Hemant Agrawal
> <hemant.agrawal at nxp.com> wrote:
> >> This patch introduce the baseband device drivers for NXP's
> >> LA1200 series software defined baseband modem.
> > Such a series deserves a cover letter.
> Ok. I will do that in v2.
> > You should copy bbdev maintainer and cryptodev subtree maintainer.
> Yes, changing the Akhil's id. He moved on.
> >
> > Quickly looked at the series, I see no change on the bbdev unit test code.
> > Are those tests running fine with no modification (I sure hope so, but
> > I want a confirmation).
> >
> Good catch! Yes, we have made the changes and we are in the process of
> cleaning them up.
> 
> We will be posting them to mailing list soon.
> 
> >> Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> >> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> >> ---
> >>   drivers/baseband/la12xx/bbdev_la12xx.c        | 110
> ++++++++++++++++++
> >>   .../baseband/la12xx/bbdev_la12xx_pmd_logs.h   |  38 ++++++
> >>   drivers/baseband/la12xx/meson.build           |   6 +
> >>   drivers/baseband/la12xx/version.map           |   3 +
> >>   drivers/baseband/meson.build                  |   2 +-
> >>   5 files changed, 158 insertions(+), 1 deletion(-)
> >>   create mode 100644 drivers/baseband/la12xx/bbdev_la12xx.c
> >>   create mode 100644
> drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h
> >>   create mode 100644 drivers/baseband/la12xx/meson.build
> >>   create mode 100644 drivers/baseband/la12xx/version.map
> >>
> > [snip]
> >
> >> +};
> >> +
> >> +RTE_PMD_REGISTER_VDEV(DRIVER_NAME, bbdev_la12xx_pmd_drv);
> >> +RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, bbdev_la12xx);
> > Quick glance at this patch, no need for an alias.
> > Alias are for maintaining compatibility when drivers are renamed but
> > this is a new driver.
> Ok.
> >
> >