[dpdk-dev] [PATCH] service: clean references to removed symbol

[Van Haaren, Harry]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Thursday, April 8, 2021 1:58 PM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org; Ray Kinsella <mdr at ashroe.eu>; Neil Horman
> <nhorman at tuxdriver.com>; Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
> Subject: Re: [PATCH] service: clean references to removed symbol
> 
> On Thu, Apr 8, 2021 at 2:54 PM Van Haaren, Harry
> <harry.van.haaren at intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: David Marchand <david.marchand at redhat.com>
> > > Sent: Wednesday, April 7, 2021 10:07 AM
> > > To: dev at dpdk.org
> > > Cc: stable at dpdk.org; Van Haaren, Harry <harry.van.haaren at intel.com>; Ray
> > > Kinsella <mdr at ashroe.eu>; Neil Horman <nhorman at tuxdriver.com>; Pavan
> > > Nikhilesh <pbhagavatula at caviumnetworks.com>
> > > Subject: [PATCH] service: clean references to removed symbol
> > >
> > > rte_service_get_id() was removed in v17.11 but the API description
> > > still referenced it and a version node was still present in EAL map.
> > >
> > > Fixes: 8edc9aaaf217 ("service: use id in get by name function")
> > > Cc: stable at dpdk.org
> > >
> > > Signed-off-by: David Marchand <david.marchand at redhat.com>
> >
> > For rte_service.h doc changes I'm all fine.
> >
> > For ABI consistency, this removes a function from the DPDK_21 version map that
> didn't exist in
> > the shared object itself. I'm not sure if that's an ABI break or not... I see ABI
> experts on CC,
> > and will let them comment on that topic.
> 
> The symbol is not in the API anymore.
> Applications can't have a reference to this symbol without a definition.

Agreed, however I'm not familiar enough with linking/ABI stability to
know if removing a symbol (even when not available in the API) could
affect the resulting shared object's ABI.

If somebody says there's no risk in ABI break, go ahead and merge. -Harry