[dpdk-dev] [PATCH v18 3/3] config: fix Arm implementer and its SoCs

[Juraj Linkeš]

> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang at arm.com>
> Sent: Friday, April 9, 2021 10:27 AM
> To: Juraj Linkeš <juraj.linkes at pantheon.tech>; bruce.richardson at intel.com;
> Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>;
> vcchunga at amazon.com; Dharmik Thakkar <Dharmik.Thakkar at arm.com>;
> jerinjacobk at gmail.com; hemant.agrawal at nxp.com; Ajit Khaparde
> (ajit.khaparde at broadcom.com) <ajit.khaparde at broadcom.com>;
> ferruh.yigit at intel.com; aboyer at pensando.io
> Cc: dev at dpdk.org; lironh at marvell.com; yskoh at mellanox.com; nd
> <nd at arm.com>
> Subject: RE: [PATCH v18 3/3] config: fix Arm implementer and its SoCs
> 
> > -----Original Message-----
> > From: Juraj Linkeš <juraj.linkes at pantheon.tech>
> > Sent: Friday, April 9, 2021 2:36 PM
> > To: bruce.richardson at intel.com; Ruifeng Wang <Ruifeng.Wang at arm.com>;
> > Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>; Phil Yang
> > <Phil.Yang at arm.com>; vcchunga at amazon.com; Dharmik Thakkar
> > <Dharmik.Thakkar at arm.com>; jerinjacobk at gmail.com;
> > hemant.agrawal at nxp.com; Ajit Khaparde (ajit.khaparde at broadcom.com)
> > <ajit.khaparde at broadcom.com>; ferruh.yigit at intel.com;
> > aboyer at pensando.io
> > Cc: dev at dpdk.org; Juraj Linkeš <juraj.linkes at pantheon.tech>;
> > lironh at marvell.com; yskoh at mellanox.com
> > Subject: [PATCH v18 3/3] config: fix Arm implementer and its SoCs
> >
> > Fix the implementer and part number of DPAA and ARMADA SoCs.
> > The current values of 16 cores and 1 NUMA node don't cover all SoCs
> > from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA
> nodes.
> > Increase these to 64 and 4 to widen the coverage.
> > Add configuration to SoC options where smaller values are needed.
> >
> > Fixes: 6ec78c2463ac ("build: add meson support for dpaaX platforms")
> > Cc: hemant.agrawal at nxp.com
> > Fixes: dd1cd845c102 ("config: add Marvell ARMADA based on armv8-a")
> > Cc: lironh at marvell.com
> > Fixes: d97108a33231 ("config: change defaults of armv8")
> > Cc: yskoh at mellanox.com
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes at pantheon.tech>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> > Reviewed-by: Liron Himi <lironh at marvell.com>
> > Acked-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
> > ---
> >  config/arm/meson.build | 60
> > +++++++++++++++++++-----------------------
> >  1 file changed, 27 insertions(+), 33 deletions(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > 6fcbbf2ebc..53577267a6 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -56,7 +56,8 @@ part_number_config_arm = {
> >  			['RTE_MACHINE', '"neoverse-n1"'],
> >  			['RTE_ARM_FEATURE_ATOMICS', true],
> >  			['RTE_MAX_MEM_MB', 1048576],
> > -			['RTE_MAX_LCORE', 80]
> > +			['RTE_MAX_LCORE', 80],
> > +			['RTE_MAX_NUMA_NODES', 1]
> 
> Ampere Altra that based on Neoverse-n1 has 2-socket server.
> So MAX_LCORE should be updated to 160, and MAX_NUMA_NODES should be
> updated to 2.
> 

Ok, will update.

> >  		]
> >  	},
> >  	'0xd49': {
> > @@ -64,7 +65,8 @@ part_number_config_arm = {
> >  		'flags': [
> >  			['RTE_MACHINE', '"neoverse-n2"'],
> >  			['RTE_ARM_FEATURE_ATOMICS', true],
> > -			['RTE_MAX_LCORE', 64]
> > +			['RTE_MAX_LCORE', 64],
> > +			['RTE_MAX_NUMA_NODES', 1]
> >  		]
> >  	}
> >  }