[dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values
Dmitry Kozlyuk
dmitry.kozliuk at gmail.com
Mon Apr 12 12:03:28 CEST 2021
2021-04-12 07:59 (UTC+0000), Tal Shnaiderman:
> > Subject: Re: [PATCH] eal/windows: fix pthreads macros return values
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Hi Tal,
> >
> > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0:
> >
> > ../../../lib/librte_eal/common/eal_common_thread.c: In function
> > ‘ctrl_params_free’:
> > ../../../lib/librte_eal/windows/include/pthread.h:42:2: warning: value
> > computed is not used [-Wunused-value]
> > 42 | !DeleteSynchronizationBarrier(barrier)
> >
> > Probably applies to other functions and may fire in combination with future
> > backported patches. Hopefully since 21.05 there will be new threading API.
>
> Thanks Dmitry, it's odd that the compiler complains only now, I'd expect to see this warning even before the change.
These functions don't have "nodiscard"-like attributes,
so a call without using result was OK, now it's an expression.
> Do we know if the new threading API will be in 21.05? API changes close in 3 days and I didn't see it get reviewed/acked.
> I can change only pthread_barrier_init for now, since currently without this change Windows runtime is broken, what do you think?
(You probably mean pthread_barrier_destroy(), from which the warning comes.)
Yes, this is worth merging as soon as warnings are fixed.
Not sure new threading API will make it into 21.05.
More information about the dev
mailing list