[dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API

[Ferruh Yigit]

On 4/10/2021 3:03 PM, Bing Zhao wrote:
> The patch set includes:
>    1. API changes
>    2. testpmd adaption and guide update
>    3. driver update (only net/mlx5 impacted)
> 
> ---
> v2: add adaptions of testpmd and driver part
> ---
> 
> Bing Zhao (4):
>    ethdev: introduce indirect action APIs
>    app/test-pmd: change to indirect action command
>    doc: update user guide for indirect action
>    net/mlx5: adaption to indirect action API
> 

Hi Bing,

How the patchset constructed will cause build error in patch by patch build, 
since first patch removes some struct/functions that are in use.

One way to handle this is:
- first add new function/structs
- switch app & pmd to new function/structs
- remove old function/structs


And another issue is this support has been added on 20.11, and we are changing 
it in the second release after it.
Of course it is OK to change the API by time, that is why we have experimental 
APIs, but the concern is if the development is driven by single vendor without a 
consensus or enough reviews, and my worry is if same thing happening again.

The author and reviewers of the original patch is already cc'ed, I think it 
would be good to have their ack to the change.

Thanks,
ferruh