[dpdk-dev] [EXT] [PATCH] examples/l2fwd-crypto: remove key size validation

Akhil Goyal gakhil at marvell.com
Tue Apr 13 11:52:42 CEST 2021


> In the example application the key can be provided by the user or
> generated randomly by the example application.
> 
> Then a validation is done in order to check if the key size is
> supported in the algorithm capabilities.
> 
> As a result of patch [1] application should support the case where a
> user supplies a wrapped key.
> 
> In order to align with this patch and be able to use the app with
> wrapped keys, app should remove the validation of key size in the
> application and rely on a PMD key size validation.
> 
> The validation is removed in case the key is provided by by user, and
> kept in case the key should be generated by the application.
> 
> [1] https://www.mail-archive.com/dev@dpdk.org/msg201281.html 
> 
> Signed-off-by: Shiri Kuzin <shirik at nvidia.com>
> ---
This patch should be aligned as per the latest version of the patch.
http://patches.dpdk.org/project/dpdk/patch/20210413063718.3123698-1-matan@nvidia.com/


>  examples/l2fwd-crypto/main.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
> index a96cb94cc4..5ae2569065 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -2111,13 +2111,11 @@ check_capabilities(struct l2fwd_crypto_options
> *options, uint8_t cdev_id)
>  					cap->sym.cipher.key_size.min,
>  					cap->sym.cipher.key_size.max,
>  					cap->sym.cipher.key_size.increment)
> -						!= 0) {
> +						!= 0)
>  				RTE_LOG(DEBUG, USER1,
> -					"Device %u does not support cipher "
> -					"key length\n",
> +					"Key length does not match the
> device "
> +					"%u capability\n",
>  					cdev_id);
> -				return -1;
> -			}
>  		/*
>  		 * Check if length of the cipher key to be randomly generated
>  		 * is supported by the algorithm chosen.
> --
> 2.21.0



More information about the dev mailing list