[dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check

Kinsella, Ray mdr at ashroe.eu
Tue Apr 13 18:09:25 CEST 2021



On 13/04/2021 09:45, Thomas Monjalon wrote:
> The eventdev driver DLB was removed in DPDK 21.05,
> breaking the ABI check.
> The exception was agreed so we just need to skip this check.
> 
> Note: complete removal of a driver cannot be ignored
> in devtools/libabigail.abignore, so the script must be patched.
> 
> Fixes: 698fa829415d ("event/dlb: remove driver")
> 
> Reported-by: David Marchand <david.marchand at redhat.com>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> ---
> This should have been done as part of removing the driver.
> The CI is currently broken, so it should be merged today.
> ---
>  devtools/check-abi.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
> index 9835e346da..ca523eb94c 100755
> --- a/devtools/check-abi.sh
> +++ b/devtools/check-abi.sh
> @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
>  		echo "Skipped glue library $name."
>  		continue
>  	fi
> +	if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
> +		echo "Skipped removed driver $name."
> +		continue
> +	fi

So this is brute force fix - we can anticipate this problem happening again.
Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?


More information about the dev mailing list