[dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows

Jie Zhou jizh at linux.microsoft.com
Wed Apr 14 00:07:25 CEST 2021


On Tue, Apr 13, 2021 at 06:58:16PM +0000, Tal Shnaiderman wrote:
> > Subject: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on
> > Windows
> > 
> > External email: Use caution opening links or attachments
> > 
> > 
> > From: Jie Zhou <jizh at microsoft.com>
> > 
> 
> I think this patch can be split further since it contains different topics, I would've split it at least to the following:
> 
> 1) Resolve name collisions with Windows types.
> 2) Add clock_gettime_monotic for testpmd on Windows.
> 3) Replace unix specific functions and code to OS independent.
> 4) build testpmd. 
> 
> > This patch is to enable testpmd on windows. It mainly includes:
> > - Disable unsupported Apps on Windows under app\ except testpmd
> Patch 4
> > - Resolve name collisions with Windows types
> Patch 1
> > - Add clock_gettime_monotic for testpmd on Windows
> Patch 2
> > - Make printf format work for both Linux and Windows
> Patch 3
> > - Replace htons with RTE_BE16
> Patch 3
> > - Replace inet_aton with inet_pton
> Patch 3, also explain why this change is needed
> > - Fix parse_fec_mode to return fec_capa to remove compilation warning
> Patch 3, unless this is a real fix and needs its own patch.
> > - Replace mman.h POSIX APIs with rte_mem_xxx APIs
> Patch 3
> > - Use OS independant rte_rand
> Patch 3
> > 
> > Signed-off-by: Jie Zhou <jizh at microsoft.com>
> > Signed-off-by: Jie Zhou <jizh at linux.microsoft.com>
> > ---

Thanks Tal. Will have more granular patches in V4.


More information about the dev mailing list