[dpdk-dev] [PATCH v3 8/8] app/bbdev: add test vectors for transport blocks

[Chautru, Nicolas]

> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal at nxp.com>
> Sent: Monday, April 12, 2021 10:17 PM
> 
> From: Nipun Gupta <nipun.gupta at nxp.com>
> 
> This patch adds two test vectors for transport block in network byte
> order:
> - LDPC encode for Transport Block
> - LDPC decode for Transport block
> 
> Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> ---
>  app/test-bbdev/test_vectors/ldpc_dec_tb.data | 362 ++++++++++++++
>  app/test-bbdev/test_vectors/ldpc_enc_tb.data | 482
> +++++++++++++++++++
>  2 files changed, 844 insertions(+)
>  create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_tb.data
>  create mode 100644 app/test-bbdev/test_vectors/ldpc_enc_tb.data


Do we get anything new from these additional vectors?
How does this help to change the network order in vector then change it again when it is parsed? This is the same data going into bbdev api. 
Also these vectors would be quite big (relatively large C). 
Ideally you want all existing vectors matching your PMD capability to be run seamlessly.
Let me know what I may miss, this looks unrequired. 

(...)

> --
> 2.17.1