[dpdk-dev] [PATCH v3 8/8] app/bbdev: add test vectors for transport blocks

[Chautru, Nicolas]

> -----Original Message-----
> From: Nipun Gupta <nipun.gupta at nxp.com>
> Sent: Wednesday, April 14, 2021 5:16 AM
> 
> Hi,
> 
> Apart from network order, these test vectors also add Transport Block
> modes.
> SO these seems legitimate to be added to the test cases.
> 

Hi

In other commit response you are saying you would look into adding this into a capability. In that case the network order should not be relevant in the actual test vector, purely a matter of processing the data differently in the related test component based on the PMD capability.
If you want to add a couple of new vectors, please reduce the size (C ~ 3 for instance) as Thomas was mindful to limit the size of these. 

Talking about capability I did not see the LDPC decoder LLR representation exposed. More generally are the current unit test able to pass with your PMD on your HW? 

> Regards,
> Nipun
> 
> > -----Original Message-----
> > From: Chautru, Nicolas <nicolas.chautru at intel.com>
> > Sent: Wednesday, April 14, 2021 6:40 AM
> > To: Hemant Agrawal <hemant.agrawal at nxp.com>; dev at dpdk.org;
> > gakhil at marvell.com
> > Cc: david.marchand at redhat.com; Nipun Gupta <nipun.gupta at nxp.com>
> > Subject: RE: [PATCH v3 8/8] app/bbdev: add test vectors for transport
> > blocks
> >
> >
> > > -----Original Message-----
> > > From: Hemant Agrawal <hemant.agrawal at nxp.com>
> > > Sent: Monday, April 12, 2021 10:17 PM
> > >
> > > From: Nipun Gupta <nipun.gupta at nxp.com>
> > >
> > > This patch adds two test vectors for transport block in network byte
> > > order:
> > > - LDPC encode for Transport Block
> > > - LDPC decode for Transport block
> > >
> > > Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> > > ---
> > >  app/test-bbdev/test_vectors/ldpc_dec_tb.data | 362 ++++++++++++++
> > > app/test-bbdev/test_vectors/ldpc_enc_tb.data | 482
> > > +++++++++++++++++++
> > >  2 files changed, 844 insertions(+)
> > >  create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_tb.data
> > >  create mode 100644 app/test-bbdev/test_vectors/ldpc_enc_tb.data
> >
> >
> > Do we get anything new from these additional vectors?
> > How does this help to change the network order in vector then change
> > it again when it is parsed? This is the same data going into bbdev api.
> > Also these vectors would be quite big (relatively large C).
> > Ideally you want all existing vectors matching your PMD capability to
> > be run seamlessly.
> > Let me know what I may miss, this looks unrequired.
> >
> > (...)
> >
> > > --
> > > 2.17.1