[dpdk-dev] [PATCH v3 2/2] test: fix missing check for thread creation
Min Hu (Connor)
humin29 at huawei.com
Fri Apr 16 10:21:24 CEST 2021
在 2021/4/16 1:05, Pattan, Reshma 写道:
>
>
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29 at huawei.com>
>> + if ((strcmp(env_value, "run_pdump_server_tests") == 0)) {
>> + rc = pthread_create(&thread, NULL, &send_pkts, NULL);
>> + if (rc != 0)
>> + rte_panic("Cannot start send pkts thread\n");
>> + }
>
>
> I think you still have not addressed the David comment on previous version of the patch.
> So , can you change this to something like below
>
> Option1)
> rc = pthread_create(&thread, NULL, &send_pkts, NULL);
> If ( rc ! = 0 )
> {
> rte_panic("Cannot start send pkts thread : %s\n", strerror(rc));
> }
>
> Or
>
> Option2)
> If ( pthread_create(&thread, NULL, &send_pkts, NULL) !=0 )
> rte_panic("Cannot start send pkts thread\n");
>
>
> Also,
>
>>> test: fix missing check for thread creation
> Change this subject line to "test/pdump: fix missing check for thread creation"
>
Hi, Pattan, fixed in v4, except for "test/pdump", if v4 is OK, please
modify it for me, @Ferruh, thanks.
> Thanks,
> Reshma
>
> .
>
More information about the dev
mailing list