[dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building testpmd on Windows

[Tal Shnaiderman]

> Subject: Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building
> testpmd on Windows
> 
> External email: Use caution opening links or attachments
> 
> 
> > Subject: Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building
> > testpmd on Windows
> >
> > External email: Use caution opening links or attachments
> >
> >
> > 18/04/2021 19:21, Tal Shnaiderman:
> > > Building testpmd results in 2 warnings in clang:
> > >
> > > ../app/test-pmd/config.c:4254:1: warning: unused function
> > > 'print_fdir_mask' [-Wunused-function] print_fdir_mask(struct
> > > rte_eth_fdir_masks *mask) ^
> > > ../app/test-pmd/config.c:4289:1: warning: unused function
> > > 'print_fdir_flex_payload' [-Wunused-function]
> > > print_fdir_flex_payload(struct rte_eth_fdir_flex_conf *flex_conf,
> > > uint32_t num) ^
> > > 2 warnings generated.
> >
> > Why all tests are passing in the CI?
> > I feel there is something wrong. We must test with -werror.
> 
> I know that the UNH Windows CI runs with -werror however the test didn't
> run on clang yet [1].
> This patch passed Intel compilation test on Windows, however I don't know if
> -werror is used there [2].
> 
> [1] - https://lab.dpdk.org/results/dashboard/patchsets/16593/
> [2] - http://mails.dpdk.org/archives/test-report/2021-April/188796.html

Update: the UNH test run a few minutes ago and as expected, failed with the compilation warnings.
For some reason however the test appears as 'passed' in patchwork.