[dpdk-dev] [PATCH v3] eal, power: use UINT64_MAX and UINT32_MAX

Thomas Monjalon thomas at monjalon.net
Mon Apr 19 11:43:41 CEST 2021


01/04/2021 13:22, Burakov, Anatoly:
> On 16-Mar-21 12:13 AM, Tyler Retzlaff wrote:
> > Use UINT64_MAX and UINT32_MAX instead of -1 or ~0 literal variations
> > of different explicit widths when creating masks and sentinel values.
> > 
> > some compilers generate a warning when applying a '-' to an unsigned
> > literal so avoid this by initializing with unsigned preprocessor
> > definitions where appropriate.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> 
> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>

Split in 2 patches (EAL and power) and applied, thanks.

There are other occurences to remove:
git grep -l -- '-1U'
	app/test-eventdev/test_perf_common.c
	app/test-eventdev/test_pipeline_common.c
	drivers/net/bnxt/tf_ulp/ulp_flow_db.c
	drivers/net/bnxt/tf_ulp/ulp_rte_parser.h
	drivers/net/mlx5/mlx5_rxtx_vec_neon.h

I think we should add a checkpatch test
to avoid inserting more occurences in future.
Tyler, please could you work on it?




More information about the dev mailing list