[dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

Thomas Monjalon thomas at monjalon.net
Tue Apr 20 16:33:20 CEST 2021


20/04/2021 16:20, Kevin Traynor:
> On 20/04/2021 11:04, Thomas Monjalon wrote:
> > 17/04/2021 09:39, Min Hu (Connor):
> >> +	if (eth_link == NULL) {
> >> +		RTE_ETHDEV_LOG(ERR,
> >> +			"Cannot get nowait ethdev port %u for NULL link\n",
> >> +			port_id);
> > 
> > "nowait ethdev" is not correct.
> > I think you can just remove "nowait".
> 
> The 'nowait' was just to distinguish from the otherwise identical
> message in rte_eth_link_get(). Probably it can be some way better worded.

Given they are alternative functions,
I think it is OK to have the same message.
We should not be lost in the code too much when looking for it.




More information about the dev mailing list