[dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Wed Apr 21 17:24:24 CEST 2021



> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa at intel.com>
> Sent: Wednesday, April 21, 2021 7:50 AM
> To: dev at dpdk.org; Singh, Jasvinder <jasvinder.singh at intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu at intel.com>
> Cc: Dharmappa, Savinay <savinay.dharmappa at intel.com>; stable at dpdk.org
> Subject: [PATCH v3] sched : fix traffic class oversubscription parameter
> 
> This patch fixes the traffic class oversubscription watermark
> value by initialising it with computed value of maximum watermark.
> 
> Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa at intel.com>
> Acked-by: Jasvinder Singh <jasvinder.singh at intel.com>
> ---
> v3: update the title.
> ---
>  lib/librte_sched/rte_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 7c56880681..cd87e688e4 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port
> *port,
>  #ifdef RTE_SCHED_SUBPORT_TC_OV
>  		/* TC oversubscription */
>  		s->tc_ov_wm_min = port->mtu;
> -		s->tc_ov_wm = s->tc_ov_wm_max;
>  		s->tc_ov_period_id = 0;
>  		s->tc_ov = 0;
>  		s->tc_ov_n = 0;
> @@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port
> *port,
>  #ifdef RTE_SCHED_SUBPORT_TC_OV
>  		s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile-
> >tc_period,
>  							s-
> >pipe_tc_be_rate_max);
> +		s->tc_ov_wm = s->tc_ov_wm_max;
>  #endif
>  		s->profile = subport_profile_id;
> 
> --
> 2.17.1

Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>



More information about the dev mailing list