[dpdk-dev] [PATCH v2] net/hns3: fix parse link fails code fail

[Ferruh Yigit]

On 4/26/2021 2:42 PM, Min Hu (Connor) wrote:
> From: Chengwen Feng <fengchengwen at huawei.com>
> 
> The link fails code should be parsed using the structure
> hns3_mbx_vf_to_pf_cmd, else it will parse fail.
> 
> Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
> ---
> v2:
> * kept original API interface.
> ---
>  drivers/net/hns3/hns3_mbx.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
> index eb202dd..755298f 100644
> --- a/drivers/net/hns3/hns3_mbx.c
> +++ b/drivers/net/hns3/hns3_mbx.c
> @@ -346,12 +346,20 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code)
>  }
>  
>  static void
> +
>  hns3pf_handle_link_change_event(struct hns3_hw *hw,
> -			      struct hns3_mbx_pf_to_vf_cmd *req)
> +				struct hns3_mbx_pf_to_vf_cmd *cmd)
>  {
>  #define LINK_STATUS_OFFSET     1
>  #define LINK_FAIL_CODE_OFFSET  2
>  
> +	/*
> +	 * This message is reported by the firmware and is reported in
> +	 * 'struct hns3_mbx_vf_to_pf_cmd' format. Therefore, we should cast
> +	 * the cmd to 'struct hns3_mbx_vf_to_pf_cmd' first.
> +	 */
> +	struct hns3_mbx_vf_to_pf_cmd *req = (struct hns3_mbx_vf_to_pf_cmd *)cmd;
> +

Hi Connor,

I guess I am missing something obvious, why not get the parameter as 'struct
hns3_mbx_vf_to_pf_cmd' at first place?