[dpdk-dev] [PATCH-V3] config/arm: restore support for Qualcomm servers

[Juraj Linkeš]

> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot at 6wind.com>
> Sent: Thursday, April 29, 2021 11:23 AM
> To: dev at dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot at 6wind.com>; Thomas Monjalon
> <thomas at monjalon.net>; Juraj Linkeš <juraj.linkes at pantheon.tech>; Honnappa
> Nagarahalli <honnappa.nagarahalli at arm.com>; Ruifeng Wang
> <ruifeng.wang at arm.com>
> Subject: [PATCH-V3] config/arm: restore support for Qualcomm servers
> 
> From the documentation:
> "The SoC configuration is a combination of implementer and CPU part number
> configuration and SoC-specific configuration."
> 
> Align Qualcomm SoC configuration with the configuration of other server SoCs
> (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer
> configuration.
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
> --
> V3:
> - include doc patch
> - remove Fixes line
> V2:
> - use the right original commit in Fixes
> ---
>  config/arm/meson.build                              | 8 ++++++++
>  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 22cd81319c06..4518b7e877b3 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -298,6 +298,13 @@ soc_octeontx2 = {
>      'numa': false
>  }
> 
> +soc_qualcomm = {
> +    'description': 'Qualcomm Centriq 2400',
> +    'implementer': '0x51',
> +    'part_number': '0xc00',
> +    'numa': false
> +}
> +
>  soc_stingray = {
>      'description': 'Broadcom Stingray',
>      'implementer': '0x41',
> @@ -334,6 +341,7 @@ socs = {
>      'n1sdp': soc_n1sdp,
>      'n2': soc_n2,
>      'octeontx2': soc_octeontx2,
> +    'qualcomm': soc_qualcomm,
>      'stingray': soc_stingray,
>      'thunderx2': soc_thunderx2,
>      'thunderxt88': soc_thunderxt88
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index 3e170436cd4f..5513948c9037 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -211,6 +211,7 @@ Substitute <target_soc> with one of the supported
> SoCs::
>     n1sdp:       Arm Neoverse N1SDP
>     n2:          Arm Neoverse N2
>     octeontx2:   Marvell OCTEON TX2
> +   qualcomm:    Qualcomm Centriq 2400

Now that I think about it, 'qualcomm' isn't a suitable name for an soc, as it's the name of the company, not the soc. The description says this is the Centriq 2400 soc, so I suggest renaming it to that (qualcomm -> centriq2400 and soc_qualcomm -> soc_centriq2400 or something similar).

>     stingray:    Broadcom Stingray
>     thunderx2:   Marvell ThunderX2 T99
>     thunderxt88: Marvell ThunderX T88
> --
> 2.29.2
>