[dpdk-dev] [PATCH v2] net/virtio: fix repeated memory free of vq

Gaoxiang Liu gaoxiangliu0 at 163.com
Thu Aug 5 10:08:37 CEST 2021






On 08/04/2021 07:45, Gaoxiang Liu wrote:
When virtio_init_queue returns error, the memory of vq is freed.
But the value of hw->vqs[queue_idx] does not restore.
If hw->vqs[queue_idx] != NULL, the memory of vq is freed again
in virtio_free_queues.

Fixes: 69c80d4ef89b ("net/virtio: allocate queue at init stage")
Cc: stable at dpdk.org

Signed-off-by: Gaoxiang Liu <gaoxiangliu0 at 163.com>

v2:
fix spelling warning
---
drivers/net/virtio/virtio_ethdev.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 056830566..fc72d71cb 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -631,6 +631,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t queue_idx)
     rte_memzone_free(mz);
free_vq:
     rte_free(vq);
+     hw->vqs[queue_idx] = NULL;

     return ret;
}
--
2.32.0


More information about the dev mailing list