[dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function

Thomas Monjalon thomas at monjalon.net
Sat Aug 7 21:34:08 CEST 2021


> > > Currently there is a dedicated modify function for each
> > > field that the application wants to change.
> > > For example:
> > > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP.
> > > rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.
> > >
> > > A new function rte_flow_action_modify_field DPDK added the ability
> > > to use the same function to modify any field, in addition to be able to
> > > modify the value based on different field and not just immediate value.
> > >
> > > Signed-off-by: Ori Kam <orika at nvidia.com>
> > > Acked-by: Matan Azrad <matan at nvidia.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> Acked-by: Jerin Jacob <jerinj at marvell.com>

> > > +* ethdev: Announce moving from dedicated modify function for each field,
> > > +  to using the general ``rte_flow_modify_field`` action.

This is a very vague announce.
OK we can replace a lot of actions with rte_flow_modify_field,
but it doesn't say when and which functions will be removed.
I think we should make a more precise announce for removal of some actions
in DPDK 22.11.

In the meantime, let's introduce this hint that something is changing
as it is acked.

Applied.




More information about the dev mailing list