[dpdk-dev] 回复: [PATCH v1 2/2] devtools: use absolute path for the build directory

[Feifei Wang]

Hi, Thomas

Thanks for your reviewing.

I agree with your comment. 
As your concern, this patch is simple but may have some negative effects.
Thus I will drop it from series in the next version.

Best Regards
Feifei

> -----邮件原件-----
> 发件人: Thomas Monjalon <thomas at monjalon.net>
> 发送时间: Friday, August 6, 2021 11:43 PM
> 收件人: Phil Yang <Phil.Yang at arm.com>; Feifei Wang
> <Feifei.Wang2 at arm.com>
> 抄送: Bruce Richardson <bruce.richardson at intel.com>; dev at dpdk.org; nd
> <nd at arm.com>; Juraj Linkeš <juraj.linkes at pantheon.tech>; Ruifeng Wang
> <Ruifeng.Wang at arm.com>; david.marchand at redhat.com
> 主题: Re: [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the
> build directory
> 
> 01/06/2021 03:56, Feifei Wang:
> > From: Phil Yang <phil.yang at arm.com>
> >
> > To make the code easier to maintain, use the absolute path for the
> > default build_dir to avoid repeatedly calling of readlink.
> [...]
> > --- a/devtools/test-meson-builds.sh
> > +++ b/devtools/test-meson-builds.sh
> > -builds_dir=${DPDK_BUILD_TEST_DIR:-.}
> > +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.})
> 
> It means that all uses of builds_dir will get the absolute path.
> It may have consequences on meson configuration, and will make outputs
> and logs longer.
> 
> I'm not sure this change is desirable.
>