[PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister
Ananyev, Konstantin
konstantin.ananyev at intel.com
Thu Dec 2 14:01:26 CET 2021
> > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > Sent: Thursday, 2 December 2021 08.19
> >
> > 01/12/2021 22:37, Tyler Retzlaff:
> > > On Wed, Nov 24, 2021 at 06:04:56PM +0000, Bruce Richardson wrote:
> > > > if (ret < 0 && rte_errno == EAGAIN)
> > >
> > > i only urge that this be explicit as opposed to a range i.e. ret == -
> > 1
> > > preferred over ret < 0
> >
> > I don't understand why you think it is important to limit return value
> > to -1.
> > Why "if (ret == -1)" is better than "if (ret < 0)" ?
>
> Speaking for myself:
>
> For clarity. It leaves no doubt that "it failed" is represented by the return value -1, and that the function does not return errno values such as
> -EINVAL.
>
But why '< 0' gives you less clarity?
Negative value means failure - seems perfectly clear to me.
More information about the dev
mailing list