[dpdk-dev] Question: typedef of eventdev_info_get_t bug?

Fredrik A Lindgren Fredrik.a.Lindgren at tietoevry.com
Mon Feb 1 10:21:46 CET 2021

While debugging a driver I was looking at the code and realized that eventdev_info_get_t typedef is defined with void return value but documentation for it says it should return 0


* @return
*   Returns 0 on success
typedef void (*eventdev_info_get_t)(struct rte_eventdev *dev,
                                                          struct rte_event_dev_info *dev_info);
struct rte_eventdev_ops {
                             eventdev_info_get_t dev_infos_get;              /**< Get device info. */

While return value from it is used in lib/librte_ethdev/rte_ethdev.c:

rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info)
   diag = (*dev->dev_ops->dev_infos_get)(dev, dev_info);
   if (diag != 0) {

Driver I'm debugging doesn't have any return statement in it's dev_infos_get function which seems to cause it to have "result" of last operation done in that function as return value.
Though this behavior may be compiler specific but it should probably be clarified and updated (change prototype of stop using return value) to avoid issue with it.


More information about the dev mailing list