[dpdk-dev] [PATCH] config/arm: fix typo in meson config

[Ferruh Yigit]

On 2/2/2021 2:19 AM, Ruifeng Wang wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit at intel.com>
>> Sent: Tuesday, February 2, 2021 6:42 AM
>> To: Jan Viktorin <viktorin at rehivetech.com>; Ruifeng Wang
>> <Ruifeng.Wang at arm.com>; jerinj at marvell.com; Bruce Richardson
>> <bruce.richardson at intel.com>; Juraj Linkeš <juraj.linkes at pantheon.tech>;
>> Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>; Vimal Chungath
>> <vcchunga at amazon.com>
>> Cc: Ferruh Yigit <ferruh.yigit at intel.com>; dev at dpdk.org;
>> thomas at monjalon.net; stable at dpdk.org; Thierry Herbelot
>> <thierry.herbelot at 6wind.com>
>> Subject: [PATCH] config/arm: fix typo in meson config
>>
>> s/implementor/implementer
>>
>> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
>> Fixes: c51401832147 ("config/arm: add Graviton2")
> 
> 'implementor' -> 'implementer' change was made in 7870ae8994c6.
> It seems 7870ae8994c6 missed Graviton2 config file which was added earlier.
> 

Right, I missed the rename patch, so it should be:
Fixes: 7870ae8994c6 ("config/arm: rename variables")

And that rename patch does 'implementor_pn' -> 'part_number', so I will update 
this patch to do the same.

> With the fix tag update,
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> 
>> Cc: stable at dpdk.org
>>
>> Reported-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>> ---
>> Cc: Juraj Linkeš <juraj.linkes at pantheon.tech>
>> Cc: Ruifeng Wang <ruifeng.wang at arm.com>
>> Cc: vcchunga at amazon.com
>> ---
>>   config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
>>   config/arm/arm64_graviton2_linux_gcc          | 4 ++--
>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
>> b/config/arm/arm64_armv8_linux_clang_ubuntu1804
>> index aa5ee0132065..ae3fb30c5da8 100644
>> --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
>> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
>> @@ -14,7 +14,7 @@ cpu = 'armv8-a'
>>   endian = 'little'
>>
>>   [properties]
>> -implementor_id = 'generic'
>> -implementor_pn = 'default'
>> +implementer_id = 'generic'
>> +implementer_pn = 'default'
>>   c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
>> c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-
>> toolchain=/usr'] diff --git a/config/arm/arm64_graviton2_linux_gcc
>> b/config/arm/arm64_graviton2_linux_gcc
>> index cfe2397975fc..123f14eed29e 100644
>> --- a/config/arm/arm64_graviton2_linux_gcc
>> +++ b/config/arm/arm64_graviton2_linux_gcc
>> @@ -13,8 +13,8 @@ cpu = 'armv8-a'
>>   endian = 'little'
>>
>>   [properties]
>> -implementor_id = '0x41'
>> -implementor_pn = '0xd0c'
>> +implementer_id = '0x41'
>> +implementer_pn = '0xd0c'
>>   max_lcores = 64
>>   max_numa_nodes = 1
>>   numa = false
>> --
>> 2.29.2
>