[dpdk-dev] [PATCH 21.05 v2] app/testpmd: support show Rx queue desc count

Ferruh Yigit ferruh.yigit at intel.com
Fri Feb 12 17:16:33 CET 2021

On 2/12/2021 2:56 PM, Lance Richardson wrote:
> Add support for querying the count of ready descriptors on a
> receive queue in order to allow the rte_eth_dev rx_queue_count()
> API to be exercised and tested.

Overall looks good to me, but there are slightly different reference to the feature,
the commit title mentions from feature as "show Rx queue desc count",
the commit log has as "count of ready descriptors",
and the documentation has "rxq desc used count",
what do you think unifying them?

> Signed-off-by: Lance Richardson <lance.richardson at broadcom.com>


> +	.f = cmd_show_rx_queue_desc_used_count_parsed,
> +	.data = NULL,
> +	.help_str = "show port <port_id> rxq <queue_id> desc used count",

Can you please add the new command to the help, 'cmd_help_long_parsed()' too?

More information about the dev mailing list