[dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage
ibtisam.tariq at emumba.com
Thu Feb 18 11:47:36 CET 2021
Thanks for the recommendation. In future, I will add a cover letter for a
long patch set.
If you want, I can submit the cover letter for this patch set too.
On Thu, Feb 18, 2021 at 2:59 PM David Marchand <david.marchand at redhat.com>
> On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq <ibtisam.tariq at emumba.com>
> > Instead of using getopt_long return value, strcmp was used to
> > compare the input parameters with the struct option array. This
> > patch get rid of all those strcmp by directly binding each longopt
> > with an int enum. This is to improve readability and consistency in
> > all examples.
> > Bugzilla ID: 238
> > Cc: marko.kovacevic at intel.com
> > Reported-by: David Marchand <david.marchand at redhat.com>
> > Signed-off-by: Ibtisam Tariq <ibtisam.tariq at emumba.com>
> For such a series, please provide a cover letter, this is easier when
> replying on the whole series (and for me when applying).
> For the series,
> Reviewed-by: David Marchand <david.marchand at redhat.com>
> There are still some unaligned examples (flow_classify, ip_reassembly,
> kni, l2fwd-crypto, l3fwd-power, multi_process/symmetric_mp, vpda,
> vmdq, vmdq_dcb), but this series is a good cleanup as is for now.
> David Marchand
More information about the dev