[dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx offload to drop error packets

[Thomas Monjalon]

18/02/2021 21:32, Ferruh Yigit:
> On 10/15/2020 2:23 PM, nipun.gupta at nxp.com wrote:
> > From: Nipun Gupta <nipun.gupta at nxp.com>
> > 
> > This change adds a Rx offload capability and configuration to
> > enable hardware to drop the packets in case of any error in the
> > packets such as L3 checksum error or L4 checksum.
> > 
> > Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> > Signed-off-by: Rohit Raj <rohit.raj at nxp.com>
> > Reviewed-by: Asaf Penso <asafp at nvidia.com>
> > ---
> 
> This feature touches many main parts,
> - new config item for 'rte_eth_dev_configure()'
> - a new offload flag
> - new capability reporting for 'rte_eth_dev_info_get()'
> 
> The feature doesn't look very mainstream to touch all these main parts and add 
> complexity to them, which will affect almost all users.
> 
> And has some inconsistencies, like configuration is done via config struct, but 
> capability is returned as bit-wise.
> Or I think config option taken into account only if offload is requested has a 
> chance to confuse people in both app and driver end.
> 
> What do you think having two specific APIs to get_capabilities and set drop config?
> The responsibility of those APIs will be clear and narrowed down, which makes it 
> harder to make it wrong.

I agree. In general, it is better adding new functions
instead of adding everything in rte_eth_dev_configure().